Dynamic pipelines using the valve element

[Clyde McQueen]

I'm struggling to create a simple dynamic pipeline with a valve element
where sync == true. My simple test case below shows a single valve element,
but my actual use case is a source with 2 tees, 3 valves and 3 sinks, where
each sink can be turned off/on independently. Any advice would be
appreciated.

I'm using the stock Ubuntu 20.04 gstreamer:
$ gst-launch-1.0 --version
gst-launch-1.0 version 1.16.2
GStreamer 1.16.2
https://launchpad.net/distros/ubuntu/+source/gstreamer1.0

My test code works until I try to turn the valve back on (drop=false), then
the buffers stop flowing.

#include <thread>

extern "C" {
#include "gst/gst.h"
#include "gst/base/gstbasesink.h"
}

class ValveTest
{
  GstElement *pipeline_;
  GstElement *src_;

  GstElement *queue_;
  GstElement *valve_;
  GstElement *sink_;

  bool valve_drop_{false};

public:
  ValveTest()
  {
    if (!gst_is_initialized()) {
      gst_init(nullptr, nullptr);
    }

    pipeline_ = gst_pipeline_new(nullptr);
    src_ = gst_element_factory_make("videotestsrc", "src");
    queue_ = gst_element_factory_make("queue", "queue");
    valve_ = gst_element_factory_make("valve", "valve");
    sink_ = gst_element_factory_make("xvimagesink", "sink");

    if (!pipeline_ || !src_ || !queue_ || !valve_ || !sink_) {
      g_critical("create failed");
      return;
    }

    gst_bin_add_many(GST_BIN(pipeline_), src_, queue_, valve_, sink_,
nullptr);

    if (!gst_element_link_many(src_, queue_, valve_, sink_, nullptr)) {
      g_critical("link src ... sink failed");
      return;
    }

    g_object_set(valve_, "drop", valve_drop_, nullptr);

    gst_base_sink_set_sync(GST_BASE_SINK(sink_), true);

    gst_element_set_state(pipeline_, GST_STATE_PLAYING);
  }

  void toggle_valve()
  {
    valve_drop_ = !valve_drop_;
    if (valve_drop_) {
      g_print("Drop\n");
      g_object_set(valve_, "drop", true, nullptr);
      gst_element_set_state(sink_, GST_STATE_NULL);
      gst_bin_remove(GST_BIN(pipeline_), sink_);
      gst_object_unref(GST_OBJECT(sink_));
      sink_ = nullptr;
    } else {
      g_print("The buffers must flow\n");
      sink_ = gst_element_factory_make("xvimagesink", "sink");
      gst_base_sink_set_sync(GST_BASE_SINK(sink_), true);
      gst_bin_add(GST_BIN(pipeline_), sink_);
      gst_element_link(valve_, sink_);
      gst_element_set_state(sink_, GST_STATE_PLAYING);
      g_object_set(valve_, "drop", false, nullptr);
    }
  }
};

int main()
{
  ValveTest test;

  while (true) {
    using namespace std::chrono_literals;
    std::this_thread::sleep_for(2s);
    test.toggle_valve();
  }

  return 0;
}

Thanks!
/Clyde
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20210830/7048d2c8/attachment.htm>