Patch: remove incorrect vbestate_restore quirk for some laptops

David Zeuthen david at fubar.dk
Wed May 2 21:22:04 PDT 2007


On Wed, 2007-05-02 at 20:51 +0200, Danny Kukawka wrote:
> You miss something in the testplan: suspend to ram has also to work from 
> console. And for your changes (remove vbestate_restore quirk) this wouldn't 
> work in the most cases! So I would vote against this changes until this get 
> rechecked with init=/bin/bash (start with init=/bin/bash, call suspendToRam, 
> resume and check if all work)

A couple of things.

First, it would be good to state something like how to test / verify
quriks like these in this part

http://people.freedesktop.org/~david/hal-spec/hal-spec.html#device-properties-power-management

of the spec. Second, as Zack pointed out earlier here

 http://lists.freedesktop.org/archives/hal/2007-April/008158.html

we have _bad_ quirks already for IBM/Lenovo. One of my colleagues from
Red Hat just verified that here

 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238792

and it goes back to what I asked here

 http://lists.freedesktop.org/archives/hal/2007-May/008207.html

The problem, in a nutshell, is that the Thinkpad quirks we imported from
s2ram are _bad_. They simply make resume after suspending to RAM _not
work_. We saw this when HAL was fixed to actually pass the quirks
instead of not passing them.

Danny: Is it possible you can ping the s2ram people at SUSE about this?
Because without any feedback the only solution is to delete all these
Thinkpad quirks from hal-info... 

Thanks.

     David


> 
> Danny
> 
> _______________________________________________
> hal mailing list
> hal at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/hal



More information about the hal mailing list