Patch: remove incorrect vbestate_restore quirk for some laptops

[Danny Kukawka]

On Donnerstag, 3. Mai 2007, David Zeuthen wrote:
> On Wed, 2007-05-02 at 20:51 +0200, Danny Kukawka wrote:
> > You miss something in the testplan: suspend to ram has also to work from
> > console. And for your changes (remove vbestate_restore quirk) this
> > wouldn't work in the most cases! So I would vote against this changes
> > until this get rechecked with init=/bin/bash (start with init=/bin/bash,
> > call suspendToRam, resume and check if all work)
>
> A couple of things.
>
> First, it would be good to state something like how to test / verify
> quriks like these in this part
>
> http://people.freedesktop.org/~david/hal-spec/hal-spec.html#device-properti
>es-power-management
>
> of the spec. 

I can take a look at this and write something, but I would prefer to start a 
new xml file for testcases and add a link there.

> Second, as Zack pointed out earlier here 
>
>  http://lists.freedesktop.org/archives/hal/2007-April/008158.html
>
> we have _bad_ quirks already for IBM/Lenovo. One of my colleagues from
> Red Hat just verified that here

I don't say all changes would be bad, but I'm sure there are several changes 
which would break suspend/resume from console, and it has to work for both.

>  https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238792
>
> and it goes back to what I asked here
>
>  http://lists.freedesktop.org/archives/hal/2007-May/008207.html
>
> The problem, in a nutshell, is that the Thinkpad quirks we imported from
> s2ram are _bad_. They simply make resume after suspending to RAM _not
> work_. We saw this when HAL was fixed to actually pass the quirks
> instead of not passing them.

Please note the meaning of the quirks in the s2ram whitelist:

#define UNSURE      0x20        /* unverified entries from acpi-support 0.59 
*/

> Danny: Is it possible you can ping the s2ram people at SUSE about this?
> Because without any feedback the only solution is to delete all these
> Thinkpad quirks from hal-info...

I add Stefan to CC, he is our s2ram maintainer. 

Btw. suspend via s2ram work perfectly for me on a X41 with the existing quirks 
on SUSE with actual kernel/X/pm-utils/s2ram.

Danny