Replacement for hal-setup-keymap -- committed to udev-extras

[Lennart Poettering]

On Sun, 10.05.09 08:17, Dan Nicholson (dbn.lists at gmail.com) wrote:

> On Sat, May 9, 2009 at 3:39 AM, Martin Pitt <martin.pitt at ubuntu.com> wrote:
> > Martin Pitt [2009-05-08 15:28 +0200]:
> >> As discussed, it is done now, including conversion of all of
> >> hal-info's current keymaps. I created my own udev-extra branch for
> >> that, since I'm still waiting for a git.kernel.org account.
> >
> > I got my account. I also got a lot of positive and no negative testing
> > feedback [1], so I'm reasonably confident that it's not totally
> > broken.
> >
> > I committed my stuff to udev-extras trunk now.  I don't see it on
> > http://git.kernel.org/?p=linux/hotplug/udev-extras.git;a=summary yet,
> > but I do see it in "git log" on master.k.o. I guess there's some
> > cronjob which updates http://git.kernel.org regularly? That seems to
> > work differently from what I'm used to on git.freedesktop.org.
> 
> Martin, I noticed a couple minor build tweaks. You committed something
> to check for gperf in configure.ac, but then you never use $(GPERF) in
> keymap/Makefile.am. On the same note, it might be nice to use
> AC_PROG_AWK in configure.ac and then use $(AWK) in the Makefile. Might
> as well just be safe.

Speaking of awk/gperf here:

Martin, in keyfuzz I used to ship my own copy of input.h which I then
processed with awk/gperf. The reason for that was that input.h
upstream changed quite often and I wanted to make sure that keymap
files shipped along with keyfuzz are guaranteed to be valid for the
keyfuzz binary build from the same tree. i.e. if the system input.h
was olderthan the keyfuzz version and its mappings this could cause
errors due to unknown keys.

Apparently you decided not to include input.h in the build tree. There
are certainly good reasons for doing that. However, I just want to
make sure you are aware of the consequences of that. 

Due to this udev-extras probably should have an explicit versioned
build time dependency on kernel-headers. Problem is that input.h
doesn't really install a pkg-config file if you udnerstand what i
mean. (But I guess it would make sense to add one to that package ;-))

Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/           GnuPG 0x1A015CC4