[Bug 70820] [IVB/HSW Bisected]Piglit spec/glsl-1.50/execution/geometry/core-inputs fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70820

Paul Berry <stereotype441 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Assignee|idr at freedesktop.org         |stereotype441 at gmail.com

--- Comment #1 from Paul Berry <stereotype441 at gmail.com> ---
Fixed by commit 172aec281d3d4eb0709977e0748d137e56aacd90
Author: Paul Berry <stereotype441 at gmail.com>
Date:   Wed Oct 23 07:55:09 2013 -0700

    glsl: set explicit_location correctly in lower_named_interface_blocks.

    When lower_named_interface_blocks lowers a built-in interface block
    member to an ir_variable, it needs to set explicit_location in the
    ir_variable.  Otherwise the linker gets confused and treats the
    variable as a generic varying.

    Fixes the following piglit tests, which were regressed by commit
    63974c0 (glsl: Simplify the interface to
    link_invalidate_variable_locations):
    - clip-distance-bulk-copy
    - clip-distance-in-bulk-read
    - clip-distance-in-explicitly-sized
    - clip-distance-in-param
    - clip-distance-in-values
    - core-inputs
    - gs-redeclares-both-pervertex-blocks
    - gs-redeclares-pervertex-in-only
    - redeclare-pervertex-subset-vs-to-gs
    - unsized-in-named-interface-block-gs
    - unsized-in-named-interface-block-multiple
    - unsized-in-unnamed-interface-block-gs
    - unsized-in-unnamed-interface-block-multiple

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70820

    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Matt Turner <mattst88 at gmail.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20131025/9298be5e/attachment.html>