[Bug 89064] [radeonsi] [bisected] reaction-game crashes with GLSL compiler error

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89064

Carl Worth <cworth at cworth.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|idr at freedesktop.org         |cworth at cworth.org

--- Comment #5 from Carl Worth <cworth at cworth.org> ---
Actually, looking closer at the "v2" portion of my commit message in
the proposed patch:

    v2: Instead of emitting the error as soon as the illegal
    character is lexed, we instead emit an ILLEGAL token to the
    parser. This allows the parser to allow the character as part
    of the replacement list of a macro, (since these are specified
    to allow any character). However, if such a macro is actually
    instantiated, the parser will emit an error when it goes to
    print the illegal character as part of the preprocessed
    output.

It would appear that with this patch applied, even a version of
Reactive Quake with the bug would still work fine, (since, from what I
recall, the bogusly-defined macro is never instantiated).

So, yes, I'll see about getting this patch pushed out as soon as
possible.

-Carl

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150213/f18318d1/attachment.html>