[Bug 96971] invariant qualifier is not valid for shader inputs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=96971

--- Comment #3 from Qiankun Miao <qiankun.miao at intel.com> ---
(In reply to Kenneth Graunke from comment #2)
> Should be fixed by:
> 
> commit f9f462936ad903f93829404ce99a2580ea21b725
> Author: Kenneth Graunke <kenneth at whitecape.org>
> Date:   Thu Aug 11 06:12:53 2016 -0700
> 
>     glsl: Fix invariant matching in GLSL 4.30 and GLSL ES 1.00.
>     
> commit dffa371665fc45481f6b6686e586f9be2b36a915
> Author: Kenneth Graunke <kenneth at whitecape.org>
> Date:   Thu Aug 11 11:40:25 2016 -0700
> 
>     glsl: Fix inout qualifier handling in GLSL 4.40.
> 
> I've marked the first one for stable, so Emil should backport it to 12.0.x. 
> (The latter isn't necessary as enhanced layouts support is only on master.)

Thanks Kenneth for these fixes. 
Sorry, there may be some misunderstandings before.
In Section 4.8.1 The Invariant Qualifier of GLSLangSpec.4.50.diff.pdf, the
following sentences describe invariant qualifier:
"
Only variables output from a shader (including those that are then input to a
subsequent shader) can be candidates for invariance.  This includes
user-defined output variables and the built-in output variables.
As only outputs need be declared with invariant, an output from one shader
stage will still match an input of a subsequent stage without the input being
declared as invariant.
"

The sentence "As only outputs need be declared with invariant, an output from
one shader stage will still match an input of a subsequent stage without the
input being declared as invariant" seems to say invariant doesn't need to match
between output and input and input can also be declared as invariant. What do
you think?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20160819/f942c7cf/attachment-0001.html>