[Bug 103616] Increased difference from reference image in shaders

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Nov 21 22:40:12 UTC 2017


Matt Turner <mattst88 at gmail.com> changed:

           What    |Removed                     |Added
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Matt Turner <mattst88 at gmail.com> ---
Thanks again for the bug report and bisection!

Fixed by

commit a05af1f7b8f82a38513bba31f9573cd62d82f18d
Author: Matt Turner <mattst88 at gmail.com>
Date:   Mon Nov 20 14:24:57 2017 -0800

    i965/fs: Handle negating immediates on MADs when propagating saturates

    MADs don't take immediate sources, but we allow them in the IR since it
    simplifies a lot of things. I neglected to consider that case.

    Fixes: 4009a9ead490 ("i965/fs: Allow saturate propagation to propagate
                          negations into MADs.")
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103616
    Reported-and-Tested-by: Ruslan Kabatsayev <b7.10110111 at gmail.com>
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

and tested by

commit beaea7abfa9f25460284f739fa50050a889ce6cd
Author: Matt Turner <mattst88 at gmail.com>
Date:   Mon Nov 20 14:21:43 2017 -0800

    i965/fs: Check ADD/MAD with immediates in satprop unit test

    The gen had to be changed from 4 to 6 so that we could test MAD, which
    is new on Gen6.

    mad_imm_float_neg_mov_sat tests the case fixed by the previous commit.

    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20171121/a931ee5f/attachment.html>

More information about the intel-3d-bugs mailing list