[Intel-gfx] [PATCH 2/2] drm/i915: Provide mode lines from VBT to drm

[Jesse Barnes]

On Fri, 08 May 2009 18:38:29 +0800
Ma Ling <ling.ma at intel.com> wrote:

> If sdvo get modes function can't find modes from EDID, transmit sdvo
> lvds modes from VBT to drm.

Did you confirm that this is the same order the Windows driver uses
(just to avoid untested configs)? I think Michael has the doc you need
for that...

> +	/* Fetch modes from VBT */
> +	if (dev_priv->sdvo_lvds_vbt_mode != NULL) {

> +	else if (sdvo_priv->is_lvds == true)
> +		intel_sdvo_get_lvds_modes(connector);

It's a little more linux-ish to make these both simply if (foo) checks,
but that's definitely not enough to block this going in.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
-- 
Jesse Barnes, Intel Open Source Technology Center