[Intel-gfx] [PATCH 2/2] drm/i915: Provide mode lines from VBT to drm

[Ma, Ling]

>-----Original Message-----
>From: Jesse Barnes [mailto:jbarnes at virtuousgeek.org] 
>Sent: Tuesday, May 12, 2009 9:40 AM
>To: Ma, Ling
>Cc: intel-gfx at lists.freedesktop.org
>Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Provide mode 
>lines from VBT to drm
>
>On Fri, 08 May 2009 18:38:29 +0800
>Ma Ling <ling.ma at intel.com> wrote:
>
>> If sdvo get modes function can't find modes from EDID, transmit sdvo
>> lvds modes from VBT to drm.
>
>Did you confirm that this is the same order the Windows driver uses
>(just to avoid untested configs)? I think Michael has the doc you need
>for that...
I will confirm the order Windows driver uses.
the sequence is the same with video bios initialization order , which
will first fetch information from edid, then static parameters in video bios.

thanks
Ma Ling
>
>> +	/* Fetch modes from VBT */
>> +	if (dev_priv->sdvo_lvds_vbt_mode != NULL) {
>
>> +	else if (sdvo_priv->is_lvds == true)
>> +		intel_sdvo_get_lvds_modes(connector);
>
>It's a little more linux-ish to make these both simply if (foo) checks,
>but that's definitely not enough to block this going in.
ok, fix.
>
>Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
>-- 
>Jesse Barnes, Intel Open Source Technology Center
>