[Intel-gfx] [PATCH] drm/i915: use the correct encoder type when comparing

Daniel Vetter daniel at ffwll.ch
Fri Aug 10 18:34:27 CEST 2012


On Fri, Aug 10, 2012 at 04:27:23PM +0300, Jani Nikula wrote:
> On Fri, 10 Aug 2012, Paulo Zanoni <przanoni at gmail.com> wrote:
> > From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> >
> >   - intel_encoder->type is INTEL_OUTPUT_SOMETHING
> >   - drm_encoder->encoder_type is DRM_MODE_ENCODER_SOMETHING
> >
> > Here we're using intel_encoder, so compare the oranges against
> > oranges. While at it, rename the variable to "intel_encoder" so we
> > keep our naming standards used everywhere.
> 
> intel_display.c still has plenty of 'struct intel_encoder *encoder'...
> 
> Reviewed-by: Jani Nikula <jani.nikula at intel.com>
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list