[Intel-gfx] [PATCH 25/25] drm/i915: don't write ring regs until they're set up

Jesse Barnes jbarnes at virtuousgeek.org
Wed Mar 21 22:56:46 CET 2012

On Wed, 21 Mar 2012 22:46:41 +0100
Daniel Vetter <daniel at ffwll.ch> wrote:

> On Wed, Mar 21, 2012 at 12:48:46PM -0700, Jesse Barnes wrote:
> > intel_clear_scanline_wait tries to clear ring wait conditions when we
> > turn off pipes, to prevent hanging WAIT_EVENT and similar commands.  But
> > we call it early before rings have been setup during initialization and
> > shouldn't touch the ring regs yet.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> Just a curious question: Does vlv not like this and blow up or is this
> just something that poped up in register trace/code reviewing?

Just something that popped up.  No actual harm done afaict aside from
writing some real low register address during init...

Jesse Barnes, Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120321/2079a2b5/attachment.sig>

More information about the Intel-gfx mailing list