[Intel-gfx] [PATCH 08/37] drm/i915: add DP_TP_STATUS registers

Chris Wilson chris at chris-wilson.co.uk
Thu Mar 22 11:47:03 CET 2012


On Wed, 21 Mar 2012 22:09:43 -0300, Eugeni Dodonov <eugeni.dodonov at intel.com> wrote:
> There is one set of those registers for each port.

Looks like we need an enum port in addition to enum plane and enum pipe.
And a _PORT() switcher. The idea behind having separate PIPE, PLANE,
PORT macros was that eventually we would put a
BUILD_BUG_ON(typeof(&x)!=typeof(enum pipe *)) and so catch misuse of
pipe versus plane (a common bug in the bad old days). However, that
requires the code base being cleansed of all the int plane, port;
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list