[Intel-gfx] [PATCH 04/25] drm/i915: Add basic support for parsing of VBT OEM Custom Block

[Jesse Barnes]

On Wed, 21 Mar 2012 18:30:11 -0700
Ben Widawsky <ben at bwidawsk.net> wrote:

> On Wed, 21 Mar 2012 12:48:25 -0700
> Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> 
> > From: Rohit Jain <rohit.jain at intel.com>
> > 
> > Added support for parsing the OEM Customizable Modes Block (#20)
> > in the VBIOS table.
> > 
> > Signed-off-by: Rohit Jain <rohit.jain at intel.com>
> > Reviewed-by: Shobhit Kumar <shobhit.kumar at intel.com>
> > Reviewed-by: Vijay A. Purushothaman <vijay.a.purushothaman at intel.com>
> > Acked-by: Jesse Barnes <jesse.barnes at intel.com>
> > Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com>
> > Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> > ---
> 
> I'll be honest, I haven't read through the whole series yet, but I
> really don't see the point of this patch, at least in the next few
> patches. Could we modify the commit to describe why we need this (or
> drop it)?

This one is unrelated to VLV, it's just extra VBT gravy.  Obviously it
needs to stuff the mode info somewhere though...

-- 
Jesse Barnes, Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120322/b9da71b6/attachment.sig>