[Intel-gfx] [PATCH 04/25] drm/i915: Add basic support for parsing of VBT OEM Custom Block

[Ben Widawsky]

On Thu, 22 Mar 2012 08:45:32 -0700
Jesse Barnes <jbarnes at virtuousgeek.org> wrote:

> On Wed, 21 Mar 2012 18:30:11 -0700
> Ben Widawsky <ben at bwidawsk.net> wrote:
> 
> > On Wed, 21 Mar 2012 12:48:25 -0700
> > Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > 
> > > From: Rohit Jain <rohit.jain at intel.com>
> > > 
> > > Added support for parsing the OEM Customizable Modes Block (#20)
> > > in the VBIOS table.
> > > 
> > > Signed-off-by: Rohit Jain <rohit.jain at intel.com>
> > > Reviewed-by: Shobhit Kumar <shobhit.kumar at intel.com>
> > > Reviewed-by: Vijay A. Purushothaman
> > > <vijay.a.purushothaman at intel.com> Acked-by: Jesse Barnes
> > > <jesse.barnes at intel.com> Reviewed-by: Eugeni Dodonov
> > > <eugeni.dodonov at intel.com> Signed-off-by: Artem Bityutskiy
> > > <artem.bityutskiy at linux.intel.com> Signed-off-by: Jesse Barnes
> > > <jbarnes at virtuousgeek.org> ---
> > 
> > I'll be honest, I haven't read through the whole series yet, but I
> > really don't see the point of this patch, at least in the next few
> > patches. Could we modify the commit to describe why we need this (or
> > drop it)?
> 
> This one is unrelated to VLV, it's just extra VBT gravy.  Obviously it
> needs to stuff the mode info somewhere though...
> 

THe HW can behave one in two ways, you read the info out and that is
required to advance the internal state machine to get to the next info
you care about. Or, you read the info out and nobody knows or cares. I
truly don't know how this HW works yet, but I'd say if it's the former
it should be added as a comment to the code. If it's the latter, we
should drop the patch.

$.02