[Intel-gfx] [PATCH 2/2] drm/i915/dp: Fix inconsistent indenting
Chris Wilson
chris at chris-wilson.co.uk
Tue Dec 4 09:31:33 UTC 2018
Quoting Manasi Navare (2018-12-03 22:55:16)
> On Tue, Nov 20, 2018 at 08:24:39PM +0000, Chris Wilson wrote:
> > Always show the FEC capability as it is initialised to 0 before error.
>
> That is a good point, do you think we should do the same for DSC DPCD and print
> that unconditionally?
Yes, when looking for debug prints I don't always remember under what
conditions they don't get printed. So for something like link
capabilities explicitly telling me some feature is not present is more
foolproof.
It's your call though, you need to balance debug output so that you get
the information you need without too large of a haystack. :)
-Chris
More information about the Intel-gfx
mailing list