[Intel-gfx] [PATCH] drm/i915: Rename drm_i915_gem_request to i915_request

Chris Wilson chris at chris-wilson.co.uk
Wed Feb 21 21:31:04 UTC 2018


Quoting Joonas Lahtinen (2018-02-21 18:40:51)
> Quoting Chris Wilson (2018-02-21 11:56:36)
> > We want to de-emphasize the link between the request (dependency,
> > execution and fence tracking) from GEM and so rename the struct from
> > drm_i915_gem_request to i915_request. That is we may implement the GEM
> > user interface on top of requests, but they are an abstraction for
> > tracking execution rather than an implementation detail of GEM. (Since
> > they are not tied to HW, we keep the i915 prefix as opposed to intel.)
> > 
> > In short, the spatch:
> > @@
> > 
> > @@
> > - struct drm_i915_gem_request
> > + struct i915_request
> > 
> > A corollary to contracting the type name, we also harmonise on using
> > 'rq' shorthand for local variables where space if of the essence and
> > repetition makes 'request' unwieldy. For globals and struct members,
> > 'request' is still much preferred for its clarity.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > Cc: MichaƂ Winiarski <michal.winiarski at intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> 
> Right, should not cause a mayhem when merged now.
> 
> Acked-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

And pushed before the pain starts.
-Chris


More information about the Intel-gfx mailing list