[Intel-gfx] [PATCH v9] drm/i915/icl: Check for fused-off VDBOX and VEBOX instances

kbuild test robot lkp at intel.com
Fri Feb 23 02:21:11 UTC 2018


Hi Oscar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20180222]
[cannot apply to v4.16-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Oscar-Mateo/drm-i915-icl-Check-for-fused-off-VDBOX-and-VEBOX-instances/20180223-095336
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x004-201807 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   drivers/gpu/drm/i915/intel_device_info.c: In function 'intel_device_info_init_mmio':
>> drivers/gpu/drm/i915/intel_device_info.c:619:18: error: 'I915_MAX_VCS' undeclared (first use in this function); did you mean 'I915_MAP_WC'?
     for (i = 0; i < I915_MAX_VCS; i++) {
                     ^~~~~~~~~~~~
                     I915_MAP_WC
   drivers/gpu/drm/i915/intel_device_info.c:619:18: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/i915/intel_device_info.c:631:18: error: 'I915_MAX_VECS' undeclared (first use in this function); did you mean 'I915_MAX_VCS'?
     for (i = 0; i < I915_MAX_VECS; i++) {
                     ^~~~~~~~~~~~~
                     I915_MAX_VCS
   In file included from include/linux/kernel.h:11:0,
                    from include/asm-generic/bug.h:18,
                    from arch/x86/include/asm/bug.h:82,
                    from include/linux/bug.h:5,
                    from include/linux/seq_file.h:7,
                    from include/drm/drm_print.h:31,
                    from drivers/gpu/drm/i915/intel_device_info.c:25:
>> drivers/gpu/drm/i915/intel_device_info.c:632:29: error: implicit declaration of function '_VECS'; did you mean '_VCS'? [-Werror=implicit-function-declaration]
      if (!HAS_ENGINE(dev_priv, _VECS(i)))
                                ^
   include/linux/bitops.h:7:28: note: in definition of macro 'BIT'
    #define BIT(nr)   (1UL << (nr))
                               ^~
   drivers/gpu/drm/i915/i915_drv.h:2752:35: note: in expansion of macro 'ENGINE_MASK'
     (!!((dev_priv)->info.ring_mask & ENGINE_MASK(id)))
                                      ^~~~~~~~~~~
>> drivers/gpu/drm/i915/intel_device_info.c:632:8: note: in expansion of macro 'HAS_ENGINE'
      if (!HAS_ENGINE(dev_priv, _VECS(i)))
           ^~~~~~~~~~
   cc1: some warnings being treated as errors
--
   drivers/gpu/drm/i915/intel_uncore.c: In function 'intel_uncore_prune':
>> drivers/gpu/drm/i915/intel_uncore.c:1468:19: error: 'I915_MAX_VCS' undeclared (first use in this function); did you mean 'I915_MAP_WC'?
      for (i = 0; i < I915_MAX_VCS; i++) {
                      ^~~~~~~~~~~~
                      I915_MAP_WC
   drivers/gpu/drm/i915/intel_uncore.c:1468:19: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/i915/intel_uncore.c:1469:16: error: 'FW_DOMAIN_ID_MEDIA_VDBOX0' undeclared (first use in this function); did you mean 'FW_DOMAIN_ID_MEDIA'?
       domain_id = FW_DOMAIN_ID_MEDIA_VDBOX0 + i;
                   ^~~~~~~~~~~~~~~~~~~~~~~~~
                   FW_DOMAIN_ID_MEDIA
>> drivers/gpu/drm/i915/intel_uncore.c:1478:19: error: 'I915_MAX_VECS' undeclared (first use in this function); did you mean 'I915_MAX_VCS'?
      for (i = 0; i < I915_MAX_VECS; i++) {
                      ^~~~~~~~~~~~~
                      I915_MAX_VCS
>> drivers/gpu/drm/i915/intel_uncore.c:1479:16: error: 'FW_DOMAIN_ID_MEDIA_VEBOX0' undeclared (first use in this function); did you mean 'FW_DOMAIN_ID_MEDIA_VDBOX0'?
       domain_id = FW_DOMAIN_ID_MEDIA_VEBOX0 + i;
                   ^~~~~~~~~~~~~~~~~~~~~~~~~
                   FW_DOMAIN_ID_MEDIA_VDBOX0
   In file included from include/linux/kernel.h:11:0,
                    from include/asm-generic/bug.h:18,
                    from arch/x86/include/asm/bug.h:82,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/gfp.h:5,
                    from include/linux/slab.h:15,
                    from include/linux/io-mapping.h:22,
                    from drivers/gpu/drm/i915/i915_drv.h:36,
                    from drivers/gpu/drm/i915/intel_uncore.c:24:
>> drivers/gpu/drm/i915/intel_uncore.c:1481:29: error: implicit declaration of function '_VECS'; did you mean '_VCS'? [-Werror=implicit-function-declaration]
       if (HAS_ENGINE(dev_priv, _VECS(i)))
                                ^
   include/linux/bitops.h:7:28: note: in definition of macro 'BIT'
    #define BIT(nr)   (1UL << (nr))
                               ^~
   drivers/gpu/drm/i915/i915_drv.h:2752:35: note: in expansion of macro 'ENGINE_MASK'
     (!!((dev_priv)->info.ring_mask & ENGINE_MASK(id)))
                                      ^~~~~~~~~~~
   drivers/gpu/drm/i915/intel_uncore.c:1481:8: note: in expansion of macro 'HAS_ENGINE'
       if (HAS_ENGINE(dev_priv, _VECS(i)))
           ^~~~~~~~~~
   cc1: some warnings being treated as errors

vim +619 drivers/gpu/drm/i915/intel_device_info.c

   595	
   596	/*
   597	 * Determine which engines are fused off in our particular hardware. Since the
   598	 * fuse register is in the blitter powerwell, we need forcewake to be ready at
   599	 * this point (but later we need to prune the forcewake domains for engines that
   600	 * are indeed fused off).
   601	 */
   602	void intel_device_info_init_mmio(struct drm_i915_private *dev_priv)
   603	{
   604		struct intel_device_info *info = mkwrite_device_info(dev_priv);
   605		u8 vdbox_disable, vebox_disable;
   606		u32 media_fuse;
   607		int i;
   608	
   609		if (INTEL_GEN(dev_priv) < 11)
   610			return;
   611	
   612		media_fuse = I915_READ(GEN11_GT_VEBOX_VDBOX_DISABLE);
   613	
   614		vdbox_disable = media_fuse & GEN11_GT_VDBOX_DISABLE_MASK;
   615		vebox_disable = (media_fuse & GEN11_GT_VEBOX_DISABLE_MASK) >>
   616				GEN11_GT_VEBOX_DISABLE_SHIFT;
   617	
   618		DRM_DEBUG_DRIVER("vdbox disable: %04x\n", vdbox_disable);
 > 619		for (i = 0; i < I915_MAX_VCS; i++) {
   620			if (!HAS_ENGINE(dev_priv, _VCS(i)))
   621				continue;
   622	
   623			if (!(BIT(i) & vdbox_disable))
   624				continue;
   625	
   626			info->ring_mask &= ~ENGINE_MASK(_VCS(i));
   627			DRM_DEBUG_DRIVER("vcs%u fused off\n", i);
   628		}
   629	
   630		DRM_DEBUG_DRIVER("vebox disable: %04x\n", vebox_disable);
 > 631		for (i = 0; i < I915_MAX_VECS; i++) {
 > 632			if (!HAS_ENGINE(dev_priv, _VECS(i)))

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 32079 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20180223/c844228b/attachment-0001.gz>


More information about the Intel-gfx mailing list