[Intel-gfx] [RFC i-g-t] intel-gpu-top: Rewrite the tool to be safe to use

Lionel Landwerlin lionel.g.landwerlin at intel.com
Wed Mar 28 18:56:41 UTC 2018

On 28/03/18 19:29, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin<tvrtko.ursulin at intel.com>
> intel-gpu-top is a dangerous tool which can hang machines due unsafe mmio
> register access. This patch rewrites it to use only PMU.
> Only overall command streamer busyness and GPU global data such as power
> and frequencies are included in this new version.
> For access to more GPU functional unit level data, an OA metric based tool
> like gpu-top should be used instead.
> Signed-off-by: Tvrtko Ursulin<tvrtko.ursulin at intel.com>
> Cc: Chris Wilson<chris at chris-wilson.co.uk>
> Cc: Lionel Landwerlin<lionel.g.landwerlin at intel.com>
> Cc: Petri Latvala<petri.latvala at intel.com>

Looks good to me too. Sorry, this isn't a detailed review, but since 
it's a lot safer :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20180328/56a86190/attachment.html>

More information about the Intel-gfx mailing list