[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Enable non-power-of-2 OA report sizes

Patchwork patchwork at emeril.freedesktop.org
Fri Sep 13 23:35:23 UTC 2019


== Series Details ==

Series: drm/i915/perf: Enable non-power-of-2 OA report sizes
URL   : https://patchwork.freedesktop.org/series/66697/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
debe3b5da38e drm/i915/perf: rework aging tail workaround
-:235: CHECK:SPACING: No space is necessary after a cast
#235: FILE: drivers/gpu/drm/i915/i915_perf.c:508:
+			u32 *report32 = (void *) report;

-:313: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#313: FILE: drivers/gpu/drm/i915/i915_perf.c:801:
+		report32[0] = report32[1] = 0;

-:357: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#357: FILE: drivers/gpu/drm/i915/i915_perf.c:1004:
+		report32[0] = report32[1] = 0;

total: 0 errors, 0 warnings, 3 checks, 352 lines checked
6472a0aed3d1 drm/i915/perf: Add support for report sizes that are not power of 2
-:63: CHECK:BRACES: braces {} should be used on all arms of this statement
#63: FILE: drivers/gpu/drm/i915/i915_perf.c:618:
+		if (report_size_partial < report_size) {
[...]
+		} else if (copy_to_user(buf, report, report_size))
[...]

-:69: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#69: FILE: drivers/gpu/drm/i915/i915_perf.c:624:
+			if (copy_to_user(buf, stream->oa_buffer.vaddr,
+					report_size - report_size_partial))

total: 0 errors, 0 warnings, 2 checks, 114 lines checked
757d4db65691 drm/i915/perf: Add the report format with a non-power-of-2 size



More information about the Intel-gfx mailing list