[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtk3gtkinst.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 754aea8115291304a7ca57396c32cbc516ccb843
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Mar 19 15:17:29 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Mar 19 21:08:23 2021 +0100

    cid#1474020 silence Use after free
    
    Change-Id: I3ef80e4c642b247ad228f912efa38e22ad7239e3
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112756
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 52c06df10452..745934c192c2 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -1882,6 +1882,7 @@ namespace
 
         gtk_container_add(GTK_CONTAINER(pReplacement), pWidget);
 
+        // coverity[freed_arg : FALSE] - this does not free pWidget, it is reffed by pReplacement
         g_object_unref(pWidget);
     }