[Libreoffice-ux-advise] Manage Names Dialog hit master

[Eike Rathke]

Hi Markus,

On Monday, 2011-12-05 21:37:41 +0100, Markus Mohrhard wrote:

> I also
> improved the performance for many range names and hope that we are now
> able to deal with a lot of range names in a reasonable time. I tested
> with a thousand range names and we now open in less than ten seconds
> while we needed more than 30 seconds with my old implementation.

What's the time needed with the old dialog?

> We now highlight the info text if we have an error in the name or in
> the formula. I was unable to change the background color of the range
> edit line or the name edit line.

The chart wizard does that when the data source range is invalid. It
seems to boil down to set the bit to enable background color at the
control, e.g.

    m_aED_Range.SetStyle( m_aED_Range.GetStyle() | WB_FORCECTRLBACKGROUND );

and then invoke SetControlForeground() and SetControlBackground() at the
control, see RangeChooserTabPage::isValid() in
chart2/source/controller/dialogs/tp_RangeChooser.cxx

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice-ux-advise/attachments/20111206/9e77aa5a/attachment.pgp>