[Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

[Ivan Timofeev]

Hi Michael,

13.12.2011 16:09, Michael Meeks пишет:
> On Mon, 2011-12-12 at 23:54 +0400, Ivan Timofeev wrote:
>> the bug: https://bugs.freedesktop.org/show_bug.cgi?id=41264
>>
>> briefly: in the context menus (except the toolbar's ones) icons are not
>> shown for radio menu items and for checked menu items.
>
> 	That - is/was a feature. In the gtk+ world when a menu item is a radio
> or option button, it has a [ ] or [x] checked - which is in the same
> column as an icon would be for a normal item.

I see no feature here... When icons in menus are disabled - there is no 
problem, but when they are enabled - nothing is painted at the left of a 
checkable menu item, neither a check mark [x] nor an image (see the 
attached image).
For the popups of the menubars there is no bug, only for the context 
ones, i.e. appearing by pressing a right mouse button.

If I understood you right, the MENU_FLAG_SHOWCHECKIMAGES flag was 
introduced to control whether a simple check mark [x] or an image should 
be painted with a checkable menu item; if it is so, it don't work anyway.
But may be I missed some piece of logic again :)

Cheers,
Ivan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buggy-menus.png
Type: image/png
Size: 55161 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111214/4a19556f/attachment-0001.png>