[Libreoffice] [PUSHED] Re: [PATCH] Again cppcheck cleanliness

Julien Nabet serval2412 at yahoo.fr
Fri Jan 7 23:46:22 PST 2011

Le 08/01/2011 08:39, Julien Nabet a écrit :
> On Fri, 2011-01-07 at 11:07 +0000, Caolán McNamara wrote:
> >/  On Thu, 2011-01-06 at 20:36 +0100, Guillaume Poussel wrote:
> />/  >  Hi everybody,
> />/  >
> />/  >
> />/  >  A new patch which correct cppcheck warnings in base/.
> />/
> />/  Looks good, pushed. Thanks for this.
> /
> Oops, I see now that cppcheck isn't run with sufficient -I flags to find
> includes, so it wasn't able to see that pDesc is actually used by some
> MACRO stuff which was hidden from it, so these were cppcheck false
> positives, as are probably the "missing ctor" warnings.
> I fixed up the pDesc ones again in a way to hide them from cppcheck
> again.
> We probably should figure out how to sufficient -I flags to cppcheck to
> get it to find the includes. This is probably a bit tricky unless we add
> a make cppcheck or something to libreoffice itself or something.
> C.

About cppcheck, perhaps it should be useful to use the latest version of 
cppcheck on the git repository.
I attached the git log of what has been done since 14th of December 
(date of the release of 1.46.1).
We can see that a lot of false positives have been corrected.

I don't understand too the part about hiding something from cppcheck, 
wouldn't it be better to declare a new bug to cppcheck tracker ?
But perhaps I misunderstood something

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110108/9c50d5e5/attachment-0001.htm>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cppcheck_git_log.txt
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110108/9c50d5e5/attachment-0001.txt>

More information about the LibreOffice mailing list