[Libreoffice] new crashers on master

Bjoern Michaelsen bjoern.michaelsen at canonical.com
Mon Jun 6 02:18:25 PDT 2011


Hi Caolán,

On Thu, 02 Jun 2011 16:47:02 +0100
Caolán McNamara <caolanm at redhat.com> wrote:

> The new binaryurp bridge for out-of-process uno isn't allocating
> enough space for small structs, DateTime is 14bytes, and the crasher
> in sfx2 is a return of one of those. The x86_64 bridge which the
> binaryurp stuff dispatches to assumes that return area will be
> 16bytes as the returned structure fits into two registers, so there's
> definitely 16bytes available in the normal case. Arguable the called
> code should be more forgiving, but I threw my hat at it and just
> rounded up to a size_t bytes in the binaryurp and sfx2 should now
> work again.

Awesome bughunting! As an aside this could have been the cause of those
random "crashes when having a jvm around" reports. Great to see this
fixed!

Best,

Bjoern


-- 
https://launchpad.net/~bjoern-michaelsen




More information about the LibreOffice mailing list