[Libreoffice] Compiler warnings ICC

[Kenneth Venken]

Hi,

there are a lot of compiler warnings when building ICC. It seems that
building ICC consists of extracting
src/fdb27bfe2dbe2e7b57ae194d9bf36bab-SampleICC-1.3.2.tar.gz and applying a
patch, then compiling it.
Most, if not all, of the warnings are in the SampleICC code.

"IccTagLut.cpp:4336: warning: array subscript is above array bounds" is one
of these warnings.

changing:
   if (m_XYZMatrix[0]!=1.0 || m_XYZMatrix[4]!=1.0 || m_XYZMatrix[9]!=1.0 ||
sum!=3.0) {
to
  if (m_XYZMatrix[0]!=1.0 || m_XYZMatrix[4]!=1.0 || m_XYZMatrix[8]!=1.0 ||
sum!=3.0) {

would fix this warning. (since this code is checking for the identity 3x3
matrix)

Since i'm not that familiar with the build process, the only option i see is
to manually edit the icc/SampleICC-1.3.2.patch file so that it will patch
the source.

Probably better would be to use the newer SampleICC library:
http://sourceforge.net/projects/sampleicc/files/sampleicc%20tar/SampleIcc-1.6.3/SampleICC-1.6.3.tar.gz/download
since this warning, and probably many others, are fixed upstream in 1.6.3.
But i wouldn't know how to go about it.

-- Kenneth
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110302/a5552101/attachment.html>