[Libreoffice] comment unnecessary?
anistenis at gmail.com
Sun Mar 20 13:27:52 PDT 2011
yeah, it's right, the code looks as follow:
"ImplRepository::impl_createManagerForModel: wrong BasicLibraries
pBasicManager->SetLibraryContainerInfo( aInfo );
//pBasicCont->setBasicManager( pBasicManager );
// that's not needed anymore today. The containers will retrieve
// BasicManager from the BasicManagerRepository, when needed.
// initialize the containers
impl_initDocLibraryContainers_nothrow( xBasicLibs, xDialogLibs );
So it can be deleted because it refers to //pBasicCont->setBasicManager(
2011/3/20 Christina Roßmanith <ChrRossmanith at web.de>
> I'm reviewing and applying patches removing commented code. What about the
> following lines from source/basmgr/basicmanagerrepository.cxx?
> //pBasicCont->setBasicManager( pBasicManager );
> // that's not needed anymore today. The containers will
> retrieve their associated
> // BasicManager from the BasicManagerRepository, when needed.
> I have the feeling, that the text-comment belongs to the commented line of
> code above. Is that true? In that case it can be removed as well (I'll do
> that if I get an ok for that).
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the LibreOffice