[Bug 1021750] Re: add gerrit review command

[David Ostrovsky]

Hej Miklos,

i added review command to git-review:

https://review.openstack.org/17423

Now you can review gerrit patch without using web browser, and even add 
multiline
comment message in your favorite editor, i guess vim, or whatever 
GIT_EDITOR is set ;-)

Enjoy
David

-------- Original Message --------
Subject: 	[Bug 1021750] Re: add gerrit review command
Date: 	Mon, 03 Dec 2012 23:00:33 -0000
From: 	OpenStack Hudson <1021750 at bugs.launchpad.net>
Reply-To: 	Bug 1021750 <1021750 at bugs.launchpad.net>
To: 	d.ostrovsky at gmx.de



Fix proposed to branch: master
Review: https://review.openstack.org/17423

** Changed in: git-review
        Status: New => In Progress

-- 
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1021750

Title:
   add gerrit review command

Status in Git Review:
   In Progress

Bug description:
   it would be nice to have also wraper for gerrit review command:
   http://gerrit-documentation.googlecode.com/svn/Documentation/2.4.2/cmd-review.html

   Because this tool already named review may be it can be renamed to
   git-gerrit.

   The guys from #gerrit freenode channel didn't understand what git-
   review tool all about (as we tried to explain them) and have thought,
   that it can only review the gerrit patches from command line.
   Ironically that featuire ist still missing.

   With this verb review in place (after renaming) the workflow would
   like something like that:

   git gerrit download c0ff33
   look around
   git gerrit review review --code-review +2 c0ff33

   To see how other did it in python:
   https://gitorious.org/querrit/querrit

   and in bash:
   http://cgit.freedesktop.org/libreoffice/core/tree/logerrit

To manage notifications about this bug go to:
https://bugs.launchpad.net/git-review/+bug/1021750/+subscriptions




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121204/9b0a4091/attachment-0001.html>