[PATCH reworked] Reduced duplicate code (simian) / l10ntools
Chr. Rossmanith
ChrRossmanith at gmx.de
Mon Feb 6 01:34:39 PST 2012
Hi again,
>
> The following string concatenation argument have to be passed as a
> parameter as well.
>
> + if ( pResData->bText )
> + sOutput += pResData->sTextTyp;
> + else if ( pResData->bQuickHelpText )
> + sOutput += "QuickHelpText";
> + else if ( pResData->bTitle )
> + sOutput += "Title";
>
> Otherwise, it would be always chosen from the first true branch.
>
I have replaced parameter ResData *pResData (which became ununsed) with
parameter rtl::OString sTextType. Or should it be rtl::OString&
sTextType instead?
Christina
More information about the LibreOffice
mailing list