[PATCH reworked] Reduced duplicate code (simian) / l10ntools

Ivan Timofeev timofeev.i.s at gmail.com
Mon Feb 6 02:50:51 PST 2012

On 06.02.2012 13:34, Chr. Rossmanith wrote:
> I have replaced parameter ResData *pResData (which became ununsed) with
> parameter rtl::OString sTextType. Or should it be rtl::OString&
> sTextType instead?

A reference is better, however it is not really performance-critical I 
think. But if so, reference variables are 'r'-prefixed.

And I'd remove the return statement at the end of the function, it is 
redundant there.


More information about the LibreOffice mailing list