[PATCH] [core/vcl/source/window/splitwin.cxx:2047] ->[core/vcl/source/window/splitwin.cxx:2045]:(style) Found duplicate branches for if and else.

Mariusz Dykierek mariuszdykierek at gmail.com
Sat Feb 18 05:29:57 PST 2012


I have a 'replacement' patch that actually replaces most of if...else if...else chains with
switches.
They are more legible and seem natural when choosing branches depending on the same variable.
The performance of a switch should  also be better, but turbo boost should not be expected ;).
Two declarations of unused variable removed by-the-way.
Anyway, all started with cppcheck warning about duplicate branches for if-else.

Question I have, is how do I submit the patch:
 - as a reply to this thread, or
 - a new patch in a new thread?

Regards,
Mariusz Dykierek


More information about the LibreOffice mailing list