[Libreoffice] [Libreoffice-commits] .: vcl/source "fix rendering of metafiles embedded in emf+"

Radek Doulik rodo at novell.com
Thu Jan 26 00:55:24 PST 2012

Hi Stephan,

I am unable to reproduce it here. Do you have some other way to
reproduce it other then make check?

I am attaching updated patch with fixed loop. Please could you try it?


On Wed, 2012-01-25 at 10:42 +0100, Stephan Bergmann wrote:
> One thing I did notice with the first hunk of your patch is that it 
> moved "pAction = NextAction();" outside the for loop -- but that looks 
> irrelevant to the problem at hand, as ImplPlayWithRenderer appears to 
> always return true in the newly introduced if here.
> Also, forms_unoapi now triggers lots of
> > warn:legacy.osl:10979:9:/data/lo/core/cppcanvas/source/mtfrenderer/implrenderer.cxx:2715: Unknown meta action type encountered
> from within ImplPlayWithRenderer and at least once triggers that 
> function's catch (RuntimeException) block with an exception with message
> > basegfx::B2DPolyPolygon cppcanvas::tools::createTextLinesPolyPolygon(basegfx::B2DPoint, const double&, const cppcanvas::tools::TextLineInfo&),
> > ::cppcanvas::internal::createTextLinesPolyPolygon(): Unexpected strikeout case
> -- anomalies the original code did not exhibit.
> Stephan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: emf.diff
Type: text/x-patch
Size: 2681 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120126/ec05189e/attachment.bin>

More information about the LibreOffice mailing list