[REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported

Korrawit Pruegsanusak detective.conan.1412 at gmail.com
Tue Jul 10 06:59:37 PDT 2012

Hello all,

First, sorry for not using gerrit. I've tried it but got "invalid
author" error as I tried to push Muthu's patch.

The commit 11c5699dad06fb0d7fc0e458550a1dac82f8ee5f also fix fdo#50907
on master, so I propose this review for the inclusion in both -3-6 and
-3-5 branches.

Branch -3-5 didn't apply cleanly, because conflict by getLength() to
isEmpty() change, so patch attached, for both branches. I also deleted
code-indent change, which is already in master, in

Last, sorry to say this, but I didn't have time to test if it could be
build or even fix the problem. (I didn't test in both branches, but
tested in master that this really fixes the problem, please see
comment 11 in fdo bugzilla).

Thanks :-)
Best Regards,
Korrawit Pruegsanusak
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-n-759210-Certain-smartart-drawings-weren-t-imported-3-5.patch
Type: application/octet-stream
Size: 5849 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120710/440e8007/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-n-759210-Certain-smartart-drawings-weren-t-imported-3-6.patch
Type: application/octet-stream
Size: 5779 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120710/440e8007/attachment-0003.obj>

More information about the LibreOffice mailing list