Revert of hrc cleanup

Michael Stahl mstahl at redhat.com
Thu Jul 19 14:05:07 PDT 2012


On 19/07/12 21:29, Eike Rathke wrote:
> Hi Thomas,
> 
> On Wednesday, 2012-07-18 21:33:26 +0200, Thomas Arnhold wrote:

>> Is there any way to get a real checkup what string and definitions
>> are in use at all?! If not it would be safer to revert all of this
>> cleanup. Even if that's very sad...
> 
> Yes, unless we have means to prove that a resource indeed is not used.
> Latest example I stumbled over are the path type resources under
> Tools->Options->LibO->Paths, but it seems you fixed that already with
> your revert in 3e7832724e6647f6e786b0feb846b97ce8c03070. And here again
> comes the --with-dbgutil build handy that when opening that tabpage
> immediately spits out to stderr:
> 
> warn:legacy.osl:31119:1:/build/libo/core/tools/source/rc/resmgr.cxx:787: file:///build/libo/core/solver/unxlngx6/installation/opt/program/../program/resource/cuien-US.res
> Class: 273, Id: 11022. Cannot load resource! 

since probably there's no good reason why loading resources may fail,
perhaps it would be a good idea to turn this one into an assert() that
aborts, so developers pay attention.



More information about the LibreOffice mailing list