fdo#41572 Making it possible to add custom animation to master slides

[Miklos Vajna]

Hi Janit,

On Tue, May 07, 2013 at 10:55:53AM +0530, Janit Anjaria <janit92 at gmail.com> wrote:
> +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
> +/*
> + * This file is part of the LibreOffice project.
> + *
> + * This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/.
> + *
> + * This file incorporates work covered by the following license notice:
> + *
> + *   Licensed to the Apache Software Foundation (ASF) under one or more
> + *   contributor license agreements. See the NOTICE file distributed
> + *   with this work for additional information regarding copyright
> + *   ownership. The ASF licenses this file to you under the Apache
> + *   License, Version 2.0 (the "License"); you may not use this file
> + *   except in compliance with the License. You may obtain a copy of
> + *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
> + */

Wrong header, for new code, the MPL2 header should be used, see
TEMPLATE.SOURCECODE.HEADER (the license part of that header is only 4
lines).

> +//This header basically will be complemented by a .cxx file which will be dealing with usage of the declared functions which can be extended so as to use the defined animation object(which we have declared).
> +namespace sd
> +{
> +class View;

See https://wiki.documentfoundation.org/Development/Doxygen, you should
use /// to make doxygen pick up documentation. Also: no indentation?

> +namespace tools
> +{
> +//adding a value to the STLPropertySet.
> +void addValue(STL Property Ser *pSet,Int32 nHandle,const Any& rValue);

Did you compile-test this "STL Property Ser"?

Miklos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130507/8e8c16a3/attachment.pgp>