[Bug 65108] Clean-up header includes (global/local)

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Nov 7 12:16:09 PST 2013


--- Comment #19 from Michael Meeks <michael.meeks at collabora.com> ---
The ESC resolution was:

 Header includes <> vs "" etc. (Tml/Sberg)
    + easy-hack closure:
        + https://bugs.freedesktop.org/show_bug.cgi?id=65108
    + situation reasonably clear, MS compiler has a very odd use of ""
        + if we want to do a global cleanup, and be reasonably sane
          we should only use <> (Sberg)
        + problems with own vs. system version (Norbert)
            + concern with local includes vs. public ones
        + local includes have no directory path anyway (Stephan)
        + in places we do relative includes "../foo/baa.h" (Kohei)
        + helps to cleanup pre-compiled headers (Sberg)

    + we should use <> everywhere without a relative path.
        + but it's fine to continue using "" for whatever corner
          cases make sense,
          identify and restore these post-facto (Kohei)

I guess scripting this is the way to go & do it in one big commit :-)

You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20131107/48c7240c/attachment.html>

More information about the LibreOffice mailing list