[Bug 84938] replace #defined constants with ‘enum class’

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Nov 9 09:00:23 PST 2014


--- Comment #5 from Terrence Enger <lo_bugs at iseries-guru.com> ---
I have started hacking on the names starting DSID_ defined in
dbaccess/source/ui/inc/dsitems.hxx.  Some observations and questions

(*) I have the name DatasourceItemId for the class.  Is this good?

(*) The member name looks like a #defined name: uppercase with
    underscores between "words".  Does anybody care for more details?

(*) I have changed to types of data members in some other classes.  I
    do not see why these variables are necessary, but I have not dug
    into the question.

(*) So far, I have arbitrarily limited my changes to dbaccess; when
    an item goes outside the module--SfxItemSet comes to mind--I have
    cast the item to int.  Is this a reasonable way to do it?  Failing
    that, is the result worth anything?

(*) The TODO comments in DriverSettings.cxx were invaluable in
    relieving the feeling of disorientation which comes from thinking,
    over and over, "Damn.  I thought I already changed this."

My plan now is to play with Base a bit.


You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20141109/ea1485a8/attachment.html>

More information about the LibreOffice mailing list