svp pixel fomats and cairo

Caolán McNamara caolanm at
Mon Nov 23 02:56:36 PST 2015

On Mon, 2015-11-23 at 09:59 +0100, Miklos Vajna wrote:
> That would be a nice quality improvement indeed. :-)
> Do I get correctly that then basebmp would have no users, or do I 
> miss something?

Well, for the moment it would remain a mixture. Using cairo for the
"missing pieces" that didn't use basebmp and were just empty "I can't
do it" stubs. But, depending on XOR cleanup foo, yeah, we'd hopefully
go that way.

> Looks great to me. One concern is that currently online.git master 
> can build against core.git master and also against core.git 
> libreoffice-5-0, it would be nice to not break that compatibility. 
> (This also helps bisecting core.git using online.git master.)

ok, that's perfect from my side, and reduces my worry about busting
libreofficekit using stuff.

> I've pushed fc06f801ee79fd49d54c27121ae9b2904d99f09c to master, so
> online.git code can query the pixel format and act accordingly. (I.e.
> your proposed online.git change could be trivially made conditional.)

ok, though maybe the formats should be named LOK_TILEMODE_RGBA and LOK_
TILEMODE_BGRA. Cause in either case the A is in the same place. I'll
twiddle that when I merge.


More information about the LibreOffice mailing list