[Libreoffice-commits] core.git: sw/inc sw/source

[Thorsten Behrens]

Hi Ashod,

Ashod Nakashian wrote:
> commit 57446e0b60b9edbe1d72b13d664857f8d09c5048
> Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
> Date:   Wed Aug 2 22:19:00 2017 -0400
>
>     sw: store paragraph signature as rdf metadata
>
Cool feature there! :)

One issue I notice:

> @@ -579,17 +580,32 @@ void SwEditShell::SignParagraph(SwPaM* pPaM)
>          // 3. Sign it.
>          svl::crypto::Signing signing(xCert);
>          signing.AddDataRange(text.getStr(), text.getLength());
> -        OStringBuffer signature;
> -        if (!signing.Sign(signature))
> +        OStringBuffer sigBuf;
> +        if (!signing.Sign(sigBuf))
>              return;
>
Since that operates on the Writer-internal text representation (string
used being the Writer node's plain text content), that might be very
hard for non-LibreOffice programs to verify?

Cheers,

-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital signature
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20170815/62b7cd20/attachment.sig>