[Libva] [PATCH] i965_device_info: add CBR and VBR rate control flags for vdenc

[Sean V Kelley]

On Thu, 2016-08-11 at 14:55 +0300, sreerenj.balachandran at intel.com
wrote:
> > From: Sreerenj Balachandran <sreerenj.balachandran at intel.com>
> 
> Low power encode through VDENC supports both CBR and VBR.
> Make sure vaGetConfigAttribute correctly returns the supported
> list of rate control modes in VAEntrypointEncSliceLP entrypoint.

This was intentional.  I'd prefer to delay this until we get the
GuC/HuC kernel patches merged.  BRC depends on the HuC firmware...

https://patchwork.freedesktop.org/series/9011/

I'm also trying to get an interface (outside of debugfs) for the driver
to detect HuC FW loading
status in the  revised/new patch set. We'll be reusing I915_GETPARAM
likely.


Thanks,

Sean

> ---
 src/i965_device_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/i965_device_info.c b/src/i965_device_info.c
index 47fd50a..a3a1027 100644
--- a/src/i965_device_info.c
+++ b/src/i965_device_info.c
@@ -361,7 +361,7 @@ static struct hw_codec_info skl_hw_codec_info = {
     .has_hevc_encoding = 1,
     .has_lp_h264_encoding = 1,
 
-    .lp_h264_brc_mode = VA_RC_CQP,
+    .lp_h264_brc_mode = VA_RC_CQP | VA_RC_CBR | VA_RC_VBR,
 
     .num_filters = 5,
     .filters = {

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libva/attachments/20160811/25178eba/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/libva/attachments/20160811/25178eba/attachment.sig>