[Mesa-dev] [PATCH] st/mesa: implement depth texture modes

[Marek Olšák]

On Tue, Jul 20, 2010 at 4:08 PM, Brian Paul <brianp at vmware.com> wrote:

> On 07/19/2010 02:53 PM, Marek Olšák wrote:
>
>> @@ -150,7 +200,10 @@ update_textures(struct st_context *st)
>>
>>         /* if sampler view has changed dereference it */
>>         if (stObj->sampler_view)
>> -           if (check_sampler_swizzle(stObj->sampler_view,
>> stObj->base._Swizzle) || (st_view_format != stObj->sampler_view->format))
>>
>
> Please break that long line into two sub-80-column lines.
>

Please note the "-" sign, i.e. the line is removed in the patch.


>
>  +            if (check_sampler_swizzle(stObj->sampler_view,
>> +                                      stObj->base._Swizzle,
>> +                                      stObj->base.DepthMode) ||
>> +                (st_view_format != stObj->sampler_view->format))
>>               pipe_sampler_view_reference(&stObj->sampler_view, NULL);
>>
>>          sampler_view = st_get_texture_sampler_view_from_stobj(stObj,
>> pipe, st_view_format);
>> --
>>
>
>
> Have you tested with all the piglit depth-tex-modes tests?  You should
> probably run all the piglit texture tests for that matter.
>

Yes, I have tested all the piglit tests including the depth-tex-mode ones,
which now pass. There is the updated patch attached, which has all your
remarks fixed.

-Marek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20100720/ee1cd447/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-st-mesa-implement-depth-texture-modes.patch
Type: text/x-diff
Size: 5394 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20100720/ee1cd447/attachment-0001.patch>