[Mesa-dev] [RFC-PATCH 00/18] add Android support

[Chia-I Wu]

On Wed, Aug 17, 2011 at 10:26 PM, Brian Paul <brianp at vmware.com> wrote:
> On 08/17/2011 12:28 AM, Chia-I Wu wrote:
>>
>> Hi list,
>>
>> This patch series adds Android Gingerbread support to Mesa.  To begin
>> with, it only supports software rendering with softpipe.  I've tested
>> it with VirtualBox.  There are pending series that enable all other
>> gallium pipe drivers and the classic i915/i965.  I would like to see
>> how this series goes before sending them out.
>>
>> If you are familiar with Android-x86, you can replace external/mesa by
>> the master branch plus this series, and build the image like this
>>
>>  $ make -j2 iso_img BOARD_GPU_DRIVERS=swrast
>>
>> The first five patches fix build issues with Android's toolchain and
>> libc.  They are generally pretty small.
>>
>> Patch 6-8 adds Android Gingerbread support to core EGL and st/egl.
>> They are quite isolated and should be interesting to EGL developers.
>>
>> Patch 9-18 adds Android.mk's to the source tree.  The Android build
>> system will include them and build mesa when BOARD_GPU_DRIVERS is
>> defined.
>>
>> This series is RFC because Android.mk's duplicate the source lists in
>> Makefile's.  It means it will suffer from the same pain as SCons does:
>> it needs to be updated if a new file is added.  Chad has concerns
>> about this.  Since he also needs to work on that for his series, I
>> will join him and update Android.mk's accordingly.
>>
>> Other than that, please review.
>
> The new code in patch 8 seems light on comments.  Maybe you could add
> comments to the new functions and structs to explain what they do.
I will split it into 3 patches (one for st/egl, one for
winsys/android, and one for targets/egl) as well as adding comments.
> Otherwise, Reviewed-by: Brian Paul <brianp at vmware.com>
>
> -Brian
>



-- 
olv at LunarG.com