[Mesa-dev] [PATCH 01/12] mesa: Remove target parameter from dd_function_table::UnmapBuffer

Kenneth Graunke kenneth at whitecape.org
Mon Aug 22 03:00:35 PDT 2011

On 08/22/2011 12:32 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> No driver used that parameter, and most drivers ended up with a bunch
> of unused-parameter warnings because it was there.

Looks like you forgot to remove target from _mesa_buffer_unmap
(bufferobj.c:479), resulting in the following Clang warning:

warning: incompatible pointer types assigning to
   'GLboolean (*)(struct gl_context *, struct gl_buffer_object *)' from
   'GLboolean (struct gl_context *, GLenum, struct gl_buffer_object *)'
   driver->UnmapBuffer = _mesa_buffer_unmap;
                       ^ ~~~~~~~~~~~~~~~~~~~

More information about the mesa-dev mailing list