[Mesa-dev] [PATCH 01/12] mesa: Remove target parameter from dd_function_table::UnmapBuffer

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/22/2011 03:00 AM, Kenneth Graunke wrote:
> On 08/22/2011 12:32 AM, Ian Romanick wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> No driver used that parameter, and most drivers ended up with a bunch
>> of unused-parameter warnings because it was there.
> 
> Looks like you forgot to remove target from _mesa_buffer_unmap
> (bufferobj.c:479), resulting in the following Clang warning:
> 
> main/bufferobj.c:679:24:
> warning: incompatible pointer types assigning to
>    'GLboolean (*)(struct gl_context *, struct gl_buffer_object *)' from
>    'GLboolean (struct gl_context *, GLenum, struct gl_buffer_object *)'
>    [-Wincompatible-pointer-types]
>    driver->UnmapBuffer = _mesa_buffer_unmap;
>                        ^ ~~~~~~~~~~~~~~~~~~~

Good catch.  The irony is that I got off on this tangent through fixing
of other warnings.  With the GCC options that I use, a full Mesa build
generates over 11,000 warnings.  I guess it should be no surprise that I
missed warning #11,001.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk5SjhAACgkQX1gOwKyEAw9zcwCdEPOAFB8zQDc7ws3lqGqSQbk8
rnsAn3tvNQiMdiGyhCYsBUX4+qbv9XXu
=9FPP
-----END PGP SIGNATURE-----