[Mesa-dev] [PATCH 1/4] intel: Move the draw_x/draw_y to the renderbuffer where it belongs.

Chad Versace chad at chad-versace.us
Sun Jun 12 22:20:13 PDT 2011


On Tue,  7 Jun 2011 11:47:11 -0700, Eric Anholt <eric at anholt.net> wrote:
> It was originally located in the region because the tracking of
> depth/color buffers was on the regions, and getting back to the irb
> would have been tricky.  Now, we're keying off of the renderbuffer in
> more places, which means we can move these fields where they belong.
> 
> This could fix potential rendering failure with a single texture
> having multiple images attached to different renderbuffers across
> shareCtx (as far as I can tell, this was the only failure we could
> cause, since anything else should trigger intel_render_texture in
> between, for example a BindFramebuffer).
> ---
>  src/mesa/drivers/dri/i915/i830_vtbl.c             |   28 +++++++----
>  src/mesa/drivers/dri/i915/i915_vtbl.c             |   28 +++++++----
>  src/mesa/drivers/dri/i965/brw_misc_state.c        |    2 +-
>  src/mesa/drivers/dri/i965/brw_wm_surface_state.c  |    2 +-
>  src/mesa/drivers/dri/i965/gen7_misc_state.c       |   19 ++++----
>  src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |    2 +-
>  src/mesa/drivers/dri/intel/intel_blit.c           |    8 ++--
>  src/mesa/drivers/dri/intel/intel_fbo.c            |   53 +++++++++++++++++---
>  src/mesa/drivers/dri/intel/intel_fbo.h            |    8 +++-
>  src/mesa/drivers/dri/intel/intel_regions.c        |   35 --------------
>  src/mesa/drivers/dri/intel/intel_regions.h        |    7 ---
>  src/mesa/drivers/dri/intel/intel_tex_copy.c       |    2 +-
>  12 files changed, 106 insertions(+), 88 deletions(-)

Reviewed-by: Chad Versace <chad at chad-versace.us>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110612/096b4c4d/attachment.pgp>


More information about the mesa-dev mailing list