[Mesa-dev] [PATCH] llvmpipe/u_format: add support for EXT_texture_shared_exponent + EXT_packed_float

[Jose Fonseca]

Looks good AFAICT.

----- Original Message -----
> From: Dave Airlie <airlied at redhat.com>
> 
> These two are fairly unique types so add specific cases for decoding
> them.
> 
> Passes piglit fbo-clear-format and fbo-generatemipmap-format tests
> for these
> two extensions.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/gallium/auxiliary/util/u_format_pack.py |    4 +++
>  src/gallium/drivers/llvmpipe/lp_screen.c    |    4 +++
>  src/gallium/drivers/llvmpipe/lp_tile_soa.py |   36
>  ++++++++++++++++++++++++--
>  3 files changed, 41 insertions(+), 3 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/util/u_format_pack.py
> b/src/gallium/auxiliary/util/u_format_pack.py
> index 5cfbe32..d3dca2a 100644
> --- a/src/gallium/auxiliary/util/u_format_pack.py
> +++ b/src/gallium/auxiliary/util/u_format_pack.py
> @@ -149,6 +149,10 @@ def is_format_pure_signed(format):
>  
>  def native_type(format):
>      '''Get the native appropriate for a format.'''

please add an empty line here.

> +    if format.name == 'PIPE_FORMAT_R11G11B10_FLOAT':
> +        return 'uint32_t'
> +    if format.name == 'PIPE_FORMAT_R9G9B9E5_FLOAT':
> +        return 'uint32_t'
>  
>      if format.layout == PLAIN:
>          if not format.is_array():


Jose