[Mesa-dev] [PATCH 2/2] xlib: set alpha to 0xff when mapping RGB pixmaps

[Eric Anholt]

On Thu, 10 Nov 2011 18:01:47 -0700, Brian Paul <brianp at vmware.com> wrote:
> Fixes a bunch of conform regressions.
> ---
>  src/mesa/drivers/x11/xm_buffer.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mesa/drivers/x11/xm_buffer.c b/src/mesa/drivers/x11/xm_buffer.c
> index 6cf9f06..ea87b6d 100644
> --- a/src/mesa/drivers/x11/xm_buffer.c
> +++ b/src/mesa/drivers/x11/xm_buffer.c
> @@ -477,6 +477,17 @@ xmesa_MapRenderbuffer(struct gl_context *ctx,
>              return;
>           }
>  
> +         if (xrb->Base.Format == MESA_FORMAT_ARGB8888 ||
> +             xrb->Base.Format == MESA_FORMAT_RGBA8888_REV) {
> +            /* The original pixmap is RGB but we're returning an RGBA
> +             * image buffer.  Fill in the A values with 0xff.
> +             */
> +            GLuint i, *p = (GLuint *) ximage->data;
> +            for (i = 0; i < w * h; i++) {
> +               p[i] |= 0xff000000;
> +            }
> +         }
> +

If the actual storage only stores rgb, shouldn't we be claiming
MESA_FORMAT_XRGB8888 or something?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111111/bfa05f2d/attachment.pgp>