[Mesa-dev] [PATCH 05/15] intel: Remove duplicate test for texture attachment completeness.

Eric Anholt eric at anholt.net
Tue Nov 15 17:55:52 PST 2011


We are already testing this if appropriate in
intel_validate_framebuffer (FBO completeness), so no need to avoid
attaching the texture to the renderbuffer here.

This causes MESA_FORMAT_R11_G11_B10_FLOAT to now be renderable as a texture
attachment on i965.
---
 src/mesa/drivers/dri/intel/intel_fbo.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c
index c1e7bad..4a703cf 100644
--- a/src/mesa/drivers/dri/intel/intel_fbo.c
+++ b/src/mesa/drivers/dri/intel/intel_fbo.c
@@ -951,14 +951,6 @@ intel_update_wrapper(struct gl_context *ctx, struct intel_renderbuffer *irb,
    struct intel_texture_image *intel_image = intel_texture_image(texImage);
    int width, height, depth;
 
-   if (!intel_span_supports_format(texImage->TexFormat)) {
-      DBG("Render to texture BAD FORMAT %s\n",
-	  _mesa_get_format_name(texImage->TexFormat));
-      return false;
-   } else {
-      DBG("Render to texture %s\n", _mesa_get_format_name(texImage->TexFormat));
-   }
-
    intel_miptree_get_dimensions_for_image(texImage, &width, &height, &depth);
 
    irb->Base.Format = texImage->TexFormat;
-- 
1.7.7



More information about the mesa-dev mailing list