[Mesa-dev] [PATCH 4/4] i965: increase the brw eu instruction store size dynamically

Eric Anholt eric at anholt.net
Tue Nov 29 10:40:46 PST 2011


On Tue, 29 Nov 2011 16:08:39 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> Increase the brw eu instruction store size dynamically instead of just
> allocating it statically with a constant limit. This would fix something
> that 'GL_MAX_PROGRAM_INSTRUCTIONS_ARB was 16384 while the driver would
> limit it to 10000'.

I was going to caution against the other assumptions on insn pointers
staying valid in pre-gen6 code in case someone reduced the initial store
size at some point, and you'd already reduced the initial store size :)

So, in brw_clip_emit.c and brw_sf_emit.c there are a few cases
(particularly loops) where the brw_instruction * is taken from one
instruction emit and used later.  I'd be comfortable with this patch if
those were converted to using an instruction index as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111129/e28f67e9/attachment.pgp>


More information about the mesa-dev mailing list