[Mesa-dev] [PATCH 4/4] i965: increase the brw eu instruction store size dynamically

Yuanhan Liu yuanhan.liu at linux.intel.com
Tue Nov 29 21:22:22 PST 2011

On Tue, Nov 29, 2011 at 10:40:46AM -0800, Eric Anholt wrote:
> On Tue, 29 Nov 2011 16:08:39 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> > Increase the brw eu instruction store size dynamically instead of just
> > allocating it statically with a constant limit. This would fix something
> > that 'GL_MAX_PROGRAM_INSTRUCTIONS_ARB was 16384 while the driver would
> > limit it to 10000'.
> I was going to caution against the other assumptions on insn pointers
> staying valid in pre-gen6 code in case someone reduced the initial store
> size at some point, and you'd already reduced the initial store size :)
> So, in brw_clip_emit.c

I presume you were talking about brw_vec4_emit.cpp

> and brw_sf_emit.c there are a few cases
> (particularly loops) where the brw_instruction * is taken from one
> instruction emit and used later.  I'd be comfortable with this patch if
> those were converted to using an instruction index as well.

Right, I missed those. Will fix it.

Yuanhan Liu

More information about the mesa-dev mailing list